fix: fix error when parsing large definitions#35
Open
glowcloud wants to merge 1 commit intotree-sitter-grammars:masterfrom
Open
fix: fix error when parsing large definitions#35glowcloud wants to merge 1 commit intotree-sitter-grammars:masterfrom
glowcloud wants to merge 1 commit intotree-sitter-grammars:masterfrom
Conversation
char0n
reviewed
Feb 24, 2026
| int16_t row; | ||
| int32_t row; | ||
| int16_t col; | ||
| int16_t blk_imp_row; |
There was a problem hiding this comment.
Suggested change
| int16_t blk_imp_row; | |
| int32_t blk_imp_row; |
char0n
reviewed
Feb 24, 2026
| size += sizeof(int32_t); | ||
| scanner->col = *(int16_t *)&buffer[size]; | ||
| size += sizeof(int16_t); | ||
| scanner->blk_imp_row = *(int16_t *)&buffer[size]; |
There was a problem hiding this comment.
Suggested change
| scanner->blk_imp_row = *(int16_t *)&buffer[size]; | |
| scanner->blk_imp_row = *(int32_t *)&buffer[size]; |
char0n
reviewed
Feb 24, 2026
| scanner->col = *(int16_t *)&buffer[size]; | ||
| size += sizeof(int16_t); | ||
| scanner->blk_imp_row = *(int16_t *)&buffer[size]; | ||
| size += sizeof(int16_t); |
There was a problem hiding this comment.
Suggested change
| size += sizeof(int32_t); |
char0n
reviewed
Feb 24, 2026
| size += sizeof(int32_t); | ||
| *(int16_t *)&buffer[size] = scanner->col; | ||
| size += sizeof(int16_t); | ||
| *(int16_t *)&buffer[size] = scanner->blk_imp_row; |
There was a problem hiding this comment.
Suggested change
| *(int16_t *)&buffer[size] = scanner->blk_imp_row; | |
| *(int32_t *)&buffer[size] = scanner->blk_imp_row; |
char0n
reviewed
Feb 24, 2026
| *(int16_t *)&buffer[size] = scanner->col; | ||
| size += sizeof(int16_t); | ||
| *(int16_t *)&buffer[size] = scanner->blk_imp_row; | ||
| size += sizeof(int16_t); |
There was a problem hiding this comment.
Suggested change
| size += sizeof(int32_t) |
|
PR changes are not sufficient enough:
|
char0n
added a commit
to speclynx/apidom
that referenced
this pull request
Feb 24, 2026
char0n
added a commit
to speclynx/apidom
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23
Fixes an issue with parsing definitions that have over 32768 lines.
Before:
After: